Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-tooling-modules): performance opt + persistent bundle info cache #1059

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

petermuessig
Copy link
Member

  • only scan the dependencies which are UI5 packages (either having a ui5.yaml or .ui5pkg marker file)
  • avoid recursive scanning of packages
  • add verbose logging information
  • introduced persistent cache for middleware to store bundle info in .ui5-tooling-modules folder in the cwd with a hash to reduce the overhead of regenerating the bundle info without changes

Fixes #1052

…ache

* only scan the dependencies which are UI5 packages
  (either having a ui5.yaml or .ui5pkg marker file)
* avoid recursive scanning of packages
* add verbose logging information
* introduced persistent cache for middleware to store bundle info
  in `.ui5-tooling-modules` folder in the cwd with a hash to reduce
  the overhead of regenerating the bundle info without changes

Fixes #1052
@petermuessig
Copy link
Member Author

Cc: @hschaefer123 - FYI this will improve your performance again!

@petermuessig petermuessig merged commit b02e050 into main Aug 12, 2024
5 checks passed
@petermuessig petermuessig deleted the fest/ModulesPerfOpt branch August 12, 2024 11:40
@hschaefer123
Copy link

Hi @petermuessig,
looks good and the performance issue is fixed.

Just needed to move former devDeps to deps, but i think this came with 3.7.0

entry point modules must be project dependencies

BR
Holger

@petermuessig
Copy link
Member Author

Yes, correct @hschaefer123 - this is important for traceability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-tooling-modules] Performance issues starting with version >= 3.5.0
2 participants